Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
Apply citation repair in the native compact send builder after queued provider refresh. Preserve original gateway annotations while retaining repair for official OpenAI API and ChatGPT sends. Cover both destination transitions, exact annotation preservation, independent metadata stripping, and native positive controls. Document the destination boundary in the public adapter reference and structure contracts.
|
No description provided. |
…#7633) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…jun#7642) GHSA-mrhx-c7xc-m3w5 and GHSA-27r3-jxmh-p828 blocked the 2.92.0 publish. Leave the package version at 2.93.0 on dev. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…e-jun#7644) Co-authored-by: lidge-jun <243035832+lidge-jun@users.noreply.github.com>
…idge-jun#7528) Settle async Windows ACL work and native-main owner locks before fixture removal, so hosted-Windows teardowns no longer fail with EPERM after passing assertions. No retry, sleep or timeout changes. Refs lidge-jun#7515
…deterministic (lidge-jun#7552) Make the codex-runtime, client-connect and loopback-listener tests deterministic: bounded child deadlines with process milestones, and a port-0 public listener in place of the free-port-then-bind race. No sleeps or timeout increases. Refs lidge-jun#7403 lidge-jun#7404 Co-authored-by: Shreyas652 <66720396+Shreyas652@users.noreply.github.com>
lidge-jun#7598) Keep the cold first-exec of a fresh Bun copy and the PowerShell start out of two timed cases: the PATH-fallback cases share one warmed Bun copy created in a budgeted beforeAll, and the CurrentUser Root certificate inspection is replayed once before its timed case. The 10s product deadline is unchanged; a new seam test drives a deadline breach to unknown on every platform. Refs lidge-jun#7578 lidge-jun#7569
…rk752-dev-bd5-20261024
⏳ DRAFT
What to do
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
|
Closing this duplicate review after preserving the complete fix in integration commit The integrated candidate passed 40 focused tests (401 assertions) on Bun 1.4.4, plus root type and structure checks. Independent source review found no blocking defect. Broader CI remains pending on the continuing draft review; this closure does not mean the change has merged or shipped. The branch is retained. |
Summary
url_citationannotations during native/responses/compact, including omitted/null titles, nonstandard indices, and provider extension fields. Native compact opt-in declares protocol support; it does not authorize OpenAI-specific citation normalization.stripProviderInputItemMetadata()independent fromrepairUrlCitationAnnotations(). Ordinary HTTP/WS requests still repair citations only for OpenAI-operated destinations.sendProvider. A provider may change destinations while waiting for key admission, so the shared body must remain unrepaired until each physical send.Verification
Validated content for commit
b095b04adaf57c1ef1b853eddeaaba6c62792acc:bun test tests/responses/compact-key-selection.test.ts \ tests/responses/responses-url-citation-title-repair.test.ts \ tests/responses/responses-native-item-extensions-compact.test.tsbun run typecheck— passed.bun run privacy:scan— passed.bun run structure:check— passed; structure index regenerated.git diff --check— passed.docs-site/,bun install --frozen-lockfileandbun run buildwith Bun 1.4.4 — passed; 593 pages built and 84,861 internal links checked. Package manifests and lockfiles are unchanged.bun run test:changedresolved theorigin/devmerge base and selected 857 of 2,596 test files. It was stopped after more than six minutes without a test-result summary (SIGTERM, exit 143) because the selected set is disproportionate to this narrow change. This is an incomplete run, not a passing result.The full local suite has not been run: for this narrow adapter/compact change, the focused regression tests are used under the documented resource exception, with the wider test shards left to current-head CI. The PR remains draft while broader validation completes.
Checklist
Original Codex task
Summary by CodeRabbit
Bug Fixes
Documentation