Skip to content

cyttsp5 config dump #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hrdl-github wants to merge 3 commits into from
Closed

cyttsp5 config dump #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d396e8
Implement cyttsp5_hid_output_app_write_and_wait
Apr 17, 2023
58ea8a5
cyttsp5: implement sysfs to dump the configuration
Apr 17, 2023
7fc4ca9
cyttsp5: implement sysfs to dump cydata
Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
217 changes: 217 additions & 0 deletions drivers/input/touchscreen/cyttsp5.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
#define HID_OUTPUT_BL_LAUNCH_APP_SIZE 11
#define HID_OUTPUT_GET_SYSINFO 0x2
#define HID_OUTPUT_GET_SYSINFO_SIZE 5
#define HID_OUTPUT_GET_CONFIG_ROW_SIZE 0x21
#define HID_OUTPUT_READ_CONF_BLOCK 0x22
#define HID_OUTPUT_SUSPEND_SCANNING 3
#define HID_OUTPUT_SUSPEND_SCANNING_TIMEOUT_MS 1000
#define HID_OUTPUT_RESUME_SCANNING 4
#define HID_OUTPUT_MAX_CMD_SIZE 12

#define HID_DESC_REG 0x1
Expand Down Expand Up @@ -75,6 +80,7 @@
#define HID_OUTPUT_RESPONSE_CMD_OFFSET 4
#define HID_OUTPUT_RESPONSE_CMD_MASK GENMASK(6, 0)

#define HID_SYSINFO_CYDATA_OFFSET 5
#define HID_SYSINFO_SENSING_OFFSET 33
#define HID_SYSINFO_BTN_OFFSET 48
#define HID_SYSINFO_BTN_MASK GENMASK(7, 0)
Expand Down Expand Up @@ -116,6 +122,9 @@
#define SET_CMD_REPORT_TYPE(byte, type) SET_CMD_HIGH(byte, ((type) << 4))
#define SET_CMD_REPORT_ID(byte, id) SET_CMD_LOW(byte, id)

#define CY_TCH_PARM_EBID 0
#define CY_DATA_ROW_SIZE 128

/* System Information interface definitions */
struct cyttsp5_sensing_conf_data_dev {
u8 electrodes_x;
Expand Down Expand Up @@ -172,6 +181,7 @@ struct cyttsp5_sysinfo {
struct cyttsp5_tch_abs_params tch_hdr;
struct cyttsp5_tch_abs_params tch_abs[CY_TCH_NUM_ABS];
u32 key_code[HID_SYSINFO_MAX_BTN];
u8 cydata[HID_SYSINFO_SENSING_OFFSET - HID_SYSINFO_CYDATA_OFFSET];
};

struct cyttsp5_hid_desc {
Expand Down Expand Up @@ -510,6 +520,52 @@ static int cyttsp5_validate_cmd_response(struct cyttsp5 *ts, u8 code)
return 0;
}

static int cyttsp5_hid_output_app_write_and_wait(struct cyttsp5 *ts,
u8 cmd_code, u8* data,
ssize_t data_len,
u16 timeout_ms)
{
int rc;
u8 cmd[HID_OUTPUT_MAX_CMD_SIZE];

if (6 + data_len > HID_OUTPUT_MAX_CMD_SIZE)
return -E2BIG;

cmd[0] = (HID_OUTPUT_REG >> 8) & 0xFF;
put_unaligned_le16(5 + data_len, cmd + 1);
cmd[3] = HID_APP_OUTPUT_REPORT_ID;
cmd[4] = 0x0; /* Reserved */
cmd[5] = cmd_code;

if (data_len)
memcpy(cmd + 6, data, data_len);

rc = regmap_bulk_write(ts->regmap, HID_OUTPUT_REG & 0xFF, cmd, 6 + data_len);
if (rc) {
dev_err(ts->dev, "Failed to write command %d\n", rc);
return rc;
}

if (!timeout_ms)
timeout_ms = CY_HID_OUTPUT_TIMEOUT_MS;

rc = wait_for_completion_interruptible_timeout(&ts->cmd_done,
msecs_to_jiffies(timeout_ms));
if (rc <= 0) {
dev_err(ts->dev, "HID output cmd execution timed out\n");
rc = -ETIMEDOUT;
return rc;
}

rc = cyttsp5_validate_cmd_response(ts, cmd_code);
if (rc) {
dev_err(ts->dev, "Validation of the response failed\n");
return rc;
}

return 0;
}

static void cyttsp5_si_get_btn_data(struct cyttsp5 *ts)
{
struct cyttsp5_sysinfo *si = &ts->sysinfo;
Expand All @@ -528,6 +584,7 @@ static int cyttsp5_get_sysinfo_regs(struct cyttsp5 *ts)
u32 tmp;

cyttsp5_si_get_btn_data(ts);
memcpy(ts->sysinfo.cydata, ts->response_buf + HID_SYSINFO_CYDATA_OFFSET, sizeof(ts->sysinfo.cydata));

scd->max_tch = scd_dev->max_num_of_tch_per_refresh_cycle;

Expand Down Expand Up @@ -744,6 +801,149 @@ static int fill_tch_abs(struct cyttsp5_tch_abs_params *tch_abs, int report_size,
return 0;
}

static int cyttsp5_hid_output_suspend_scanning(struct cyttsp5 *ts)
{
int rc;
rc = cyttsp5_hid_output_app_write_and_wait(
ts, HID_OUTPUT_SUSPEND_SCANNING, NULL, 0,
HID_OUTPUT_SUSPEND_SCANNING_TIMEOUT_MS);
if (rc) {
dev_err(ts->dev, "Failed to suspend scanning %d\n", rc);
return rc;
}

return 0;
}

static int cyttsp5_hid_output_resume_scanning(struct cyttsp5 *ts)
{
int rc;
rc = cyttsp5_hid_output_app_write_and_wait(
ts, HID_OUTPUT_RESUME_SCANNING, NULL, 0, 0);
if (rc) {
dev_err(ts->dev, "Failed to resume scanning %d\n", rc);
return rc;
}

return 0;
}

static int cyttsp5_hid_output_get_config_row_size(struct cyttsp5 *ts,
u16 *row_size)
{
int rc;
rc = cyttsp5_hid_output_app_write_and_wait(
ts, HID_OUTPUT_GET_CONFIG_ROW_SIZE, NULL, 0, 0);
if (rc) {
dev_err(ts->dev, "Failed to get config row size %d\n", rc);
return rc;
}

*row_size = get_unaligned_le16(ts->response_buf + 5);
return 0;
}

static int cyttsp5_hid_output_read_conf_block(struct cyttsp5 *ts,
u16 row_number, u16 length,
u8 ebid, u8 *read_buf, u16 *crc)
{
int rc;
int read_ebid;
int read_length;
int status;
u8 write_buf[5];

put_unaligned_le16(row_number, write_buf);
put_unaligned_le16(length, write_buf + 2);
write_buf[4] = ebid;

rc = cyttsp5_hid_output_app_write_and_wait(ts,
HID_OUTPUT_READ_CONF_BLOCK, write_buf,
ARRAY_SIZE(write_buf), 0);
if (rc) {
dev_err(ts->dev, "Failed to read config block row=%d\n",
row_number);
return rc;
}

status = ts->response_buf[5];
if (status)
return -EINVAL;

read_ebid = ts->response_buf[6];
if ((read_ebid != ebid) || (ts->response_buf[9] != 0)) {
return -EPROTO;
}

read_length = get_unaligned_le16(ts->response_buf + 7);
if (length > read_length)
length = read_length;

memcpy(read_buf, ts->response_buf + 10, min(length, read_length));
*crc = get_unaligned_le16(ts->response_buf + read_length + 10);

return 0;
}

static ssize_t cyttsp5_sysfs_dump_cydata(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct cyttsp5 *ts = dev_get_drvdata(dev);
ssize_t len = sizeof(ts->sysinfo.cydata);
memcpy(buf, ts->sysinfo.cydata, len);
return len;
}

static ssize_t cyttsp5_sysfs_dump_config(struct device *dev,
struct device_attribute *attr, char *buf)
{
int rc;
u8 read_buf[CY_DATA_ROW_SIZE];
size_t cfg_size, bytes_written = 0, read_len = 0;
u16 crc;

struct cyttsp5 *ts = dev_get_drvdata(dev);

rc = cyttsp5_hid_output_suspend_scanning(ts);
if (rc)
return rc;

rc = cyttsp5_hid_output_read_conf_block(ts, 0, CY_DATA_ROW_SIZE,
CY_TCH_PARM_EBID, read_buf, &crc);
if (rc) {
dev_err(dev, "Failed to read first config block %d", rc);
goto resume_scanning;
}

cfg_size = get_unaligned_le16(read_buf) + 2; // CRC
read_len = min(CY_DATA_ROW_SIZE, cfg_size);
while (bytes_written < cfg_size) {
memcpy(buf + bytes_written, read_buf, read_len);
bytes_written += read_len;
read_len = min(CY_DATA_ROW_SIZE, cfg_size - bytes_written);
if (read_len > 0) {
rc = cyttsp5_hid_output_read_conf_block(ts,
bytes_written / CY_DATA_ROW_SIZE,
read_len, CY_TCH_PARM_EBID, read_buf,
&crc);
}
if (rc) {
dev_err(dev, "Failed to read config block %ld, config"
" size=%ld rc=%d",
bytes_written / CY_DATA_ROW_SIZE,
cfg_size, rc);
goto resume_scanning;
}
}
resume_scanning:
cyttsp5_hid_output_resume_scanning(ts);

return bytes_written;
}

static DEVICE_ATTR(dump_config, S_IRUGO, cyttsp5_sysfs_dump_config, NULL);
static DEVICE_ATTR(dump_cydata, S_IRUGO, cyttsp5_sysfs_dump_cydata, NULL);

static irqreturn_t cyttsp5_handle_irq(int irq, void *handle)
{
struct cyttsp5 *ts = handle;
Expand Down Expand Up @@ -864,6 +1064,16 @@ static int cyttsp5_startup(struct cyttsp5 *ts)
return error;
}

static struct attribute *cyttsp5_attrs[] = {
&dev_attr_dump_config.attr,
&dev_attr_dump_cydata.attr,
NULL
};

static const struct attribute_group cyttsp5_attr_group = {
.attrs = cyttsp5_attrs,
};

static void cyttsp5_cleanup(void *data)
{
struct cyttsp5 *ts = data;
Expand Down Expand Up @@ -910,6 +1120,13 @@ static int cyttsp5_probe(struct device *dev, struct regmap *regmap, int irq,
return error;
}

error = sysfs_create_group(&dev->kobj, &cyttsp5_attr_group);
if (error) {
dev_err(dev,
"Failed to create sysfs attributes, err: %d\n", error);
return error;
}

ts->input = devm_input_allocate_device(dev);
if (!ts->input) {
dev_err(dev, "Error, failed to allocate input device\n");
Expand Down