Repository navigation
fix(mwa): use type-safe getParcelableExtra on Android 13+ - #292
jrootcache wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. Walkthrough
ChangesChooser component lookup
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The chooser fallback has no confirmed merge-blocking issue. Confirm that the Android build compiles against API 33 or later during normal build checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change restores wallet selection on Android 13 and later without changing the broadcast checks or wallet authorization flow. Its downstream effect on cached wallet routing merits review, but no new security bypass was established. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of Changes
MwaChooserHelper.javafor Android 13+ (API level 33+) using the type-safe overloadintent.getParcelableExtra(Intent.EXTRA_CHOSEN_COMPONENT, ComponentName.class).sChosenPackageis reliably extracted when handlingACTION_CHOSENbroadcasts on modern Android versions where legacy untypedgetParcelableExtrais deprecated and may returnnull.Summary by CodeRabbit