You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(redhat): isolate signature framing and count rejections - #350
Signature fixtures now isolate complete Legacy/V0 count mismatches, truncated payloads, and missing or extra V1 signatures. Each case keeps its expected rejection stage and repaired control.
No actionable comments were generated in the recent review.
Walkthrough
The structure scenario replaces one ambiguous signature mutation with separate signature-count, missing-signature, and extra-signature cases. It adds format-specific test coverage and checks that each mutation fails at the expected parsing or sanitization stage.
The scenario adds format-specific cases for signature-count mismatches, missing signatures, and extra signatures. Count mismatches are expected to deserialize and then fail sanitization. Missing and extra signature data are expected to fail parsing.
This change only adjusts test fixtures for signature rejection cases. No merge-blocking risk is evident.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: signature fixtures now isolate count rejections and framing errors, which matches the structure.rs mutation changes (SignatureCount, MissingSignature, ExtraSignature) …
Description check
The description states that signature fixtures now isolate Legacy/V0 count mismatches, truncated payloads, and missing or extra V1 signatures, which matches the raw summary of the structure.rs changes…
Linked Issues check
Issue #345 has one direct, open, coding objective set. Each objective is addressed in redhat/src/scenarios/aperture/structure.rs at head e66a20f:
The PR summary and the AI-generated change summary report changes only in redhat/src/scenarios/aperture/structure.rs (+28/-5). These changes replace the Signatures mutation with SignatureCount, …
Full details: Title check
Explanation
The title names the main change: signature fixtures now isolate count rejections and framing errors, which matches the structure.rs mutation changes (SignatureCount, MissingSignature, ExtraSignature) and the linked issue #345. It is specific and follows conventional commit style.
Full details: Description check
Explanation
The description states that signature fixtures now isolate Legacy/V0 count mismatches, truncated payloads, and missing or extra V1 signatures, which matches the raw summary of the structure.rs changes. It also references the closed issue #345.
Full details: Linked Issues check
Explanation
Issue #345 has one direct, open, coding objective set. Each objective is addressed in redhat/src/scenarios/aperture/structure.rs at head e66a20f:
Legacy/V0 count mismatch [#345]: Mutation::SignatureCount splices one 64-byte zero signature at offset 65 (after the first signature), sets bytes[0] = 2, and calls wincode::deserialize(&bytes)?. The parse must succeed. ensure!(tx.sanitize().is_err()) then requires sanitization to fail. The gate is SanitizeError. Both Legacy and V0 are in the matrix. The first signature and message are preserved.
Legacy/V0 truncated payload [#345]: Mutation::MissingSignature sets bytes[0] = 2 and truncates to 65 + 32 bytes. The second signature needs bytes 65..129, so the packet ends before it is complete. The gate is ParseError.
V1 missing or extra signature [#345]: MissingSignature truncates the final 64 bytes. ExtraSignature appends 64 zero bytes. Both keep the version prefix and message. Both expect ParseError. ExtraSignature is in the matrix for V1.
The ambiguous prior Signatures mutation no longer exists in the file. The retained checks apply to every case for both skip_preflight values: rejection code (-32602), not_admitted, unchanged, check_control with the repaired message, and the vacant-account and base-account checks. The issue's request to replay the failing seed and extra seeds is an execution task, not a coding requirement, so it is not assessed here.
Stack objectives [#345 via PR #350]: PR #350 addresses all coding objectives on its own, so no stack-level gap remains. PR #351 (uncertain) was not inspected and is not credited.
Full details: Out of Scope Changes check
Explanation
The PR summary and the AI-generated change summary report changes only in redhat/src/scenarios/aperture/structure.rs (+28/-5). These changes replace the Signatures mutation with SignatureCount, MissingSignature, and ExtraSignature, adjust the run matrix, and add the classification and wire-mutation logic for those cases. Every changed behavior maps to the signature-fixture objectives of #345. No unrelated file or mutation change is reported.
Limitation: the whole-PR text diff could not be read because the changed blobs are missing from the checkout. The out-of-scope judgment rests on the supplied summary and the head file contents. Unchanged hunks were not verified against the base line by line.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.1)
Clippy execution failed
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 6afdd2e and e66a20f.
Files selected for processing: 1
redhat/src/scenarios/aperture/structure.rs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Signature fixtures now isolate complete Legacy/V0 count mismatches, truncated payloads, and missing or extra V1 signatures. Each case keeps its expected rejection stage and repaired control.
Closes #345