You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(redshift): stabilize program upgrade coordination - #354
Coordinate upgrade delivery through separate hot/cold proxies and an observed cold HTTP fetch, so a missed WebSocket notification cannot stall the test. Finish warm progress before starting cold loads while preserving version, rollback, and convergence checks.
No actionable comments were generated in the recent review.
Walkthrough
The program upgrade consistency scenario now uses separate proxies and fault scopes for the hot and cold ERs. It verifies that the cold ER has not materialized the program, then waits for a stalled cold account fetch before releasing the configured faults.
Changes: Program upgrade consistency
Layer / File(s)
Summary
Separate proxy and fault scopes redshift/src/scenarios/chainlink/program_upgrade_consistency.rs
The scenario creates and configures separate proxies and fault scopes for the hot and cold ERs. Invocations and hot upgrade holds use the hot fault scope. Cleanup resets both scopes and drops both proxies.
After the upgrade, the scenario checks that the cold ER has not materialized the program. It stalls the cold program-account HTTP response during three cold account fetches and releases the hot holds and cold stall after the cold response stall is observed.
This change makes the program upgrade consistency test scenario more reliable by coordinating on an observed cold fetch instead of a one-off notification. It only affects test code, and no merge-blocking risk was identified.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title "fix(redshift): stabilize program upgrade coordination" matches the main change. The change gives the hot and cold ERs separate proxies and fault scopes, and it waits for an observed cold fe…
Description check
The description states that upgrade delivery now runs through separate hot and cold proxies with an observed cold HTTP fetch. It also says warm progress finishes before cold loads start, and it links …
Linked Issues check
Issue #353 is the only directly linked active issue. Its coding requirements are: (1) avoid timeouts from a one-off WebSocket notification that reconnection does not replay; (2) avoid cross-attributio…
Out of Scope Changes check
The changes are confined to redshift/src/scenarios/chainlink/program_upgrade_consistency.rs, which the issue names as the scope. The changed logic (separate hot and cold proxies and fault scopes, held…
Full details: Title check
Explanation
The title "fix(redshift): stabilize program upgrade coordination" matches the main change. The change gives the hot and cold ERs separate proxies and fault scopes, and it waits for an observed cold fetch before it releases the hot holds. The title names the redshift scope and the upgrade coordination concern, so a reviewer scanning history can identify the primary change.
Full details: Description check
Explanation
The description states that upgrade delivery now runs through separate hot and cold proxies with an observed cold HTTP fetch. It also says warm progress finishes before cold loads start, and it links the issue it closes (#353). It directly describes the changeset.
Full details: Linked Issues check
Explanation
Issue #353 is the only directly linked active issue. Its coding requirements are: (1) avoid timeouts from a one-off WebSocket notification that reconnection does not replay; (2) avoid cross-attribution of HTTP responses between hot and cold validators; (3) avoid cold fetch deadlines spent waiting on warm traffic; (4) coordinate held delivery through an observed cold fetch; (5) keep version, rollback, and convergence checks.
Evidence at the reviewed head (redshift/src/scenarios/chainlink/program_upgrade_consistency.rs):
(1) and (4): upgrade delivery is held on the hot ER through hot_faults.stall on accountNotification/programNotification WS selectors and on HTTP getAccountInfo/getMultipleAccounts responses for program_id and programdata. The test does not depend on the WS notification arriving.
(2): hot_proxy and cold_proxy are separate Proxy instances with separate Faults scopes. cold_fetch stalls the HTTP program-account response only on the cold proxy.
(3): progress.await_count(1, after_upgrade + 8) completes warm progress before the cold loads begin.
(4): the cold fetch is observed with cold_fetch.wait_hit(TIMEOUT). Holds are removed only after that hit.
(5): Invocations::verify keeps version-marker checks and rollback checks (id.is_multiple_of(4), FAILURE_CODE). Convergence is checked by await_accounts for fresh B materialization, progress.await_count(3, 12), and ensure!(state == self.expected). run still calls finish and resets both fault scopes before dropping both proxies.
Limitation: the textual diff was unavailable, so this assessment relies on the head file content and the PR summary. It does not compare against the base revision. The requirements are satisfied by the head content. No automated test run was inspected.
Full details: Out of Scope Changes check
Explanation
The changes are confined to redshift/src/scenarios/chainlink/program_upgrade_consistency.rs, which the issue names as the scope. The changed logic (separate hot and cold proxies and fault scopes, held upgrade delivery, observed cold fetch, warm-progress ordering, and fault and proxy cleanup) directly implements issue #353. The raw summary reports no changes to exported or public declarations. No unrelated files or behavior were identified in the available evidence. The textual diff could not be read, so the check covers the file content at head and the PR summary, not a line-by-line diff against base.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.1)
Clippy execution timed out
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Coordinate upgrade delivery through separate hot/cold proxies and an observed cold HTTP fetch, so a missed WebSocket notification cannot stall the test. Finish warm progress before starting cold loads while preserving version, rollback, and convergence checks.
Closes #353