Repository navigation
refactor: flatten editor src/core into src - #9723
Merged
Merged
Conversation
Collapse the remaining src/core/ directory in @plane/editor up into src/, removing the last layer of nesting left over from the ce/ee split removal. - Move components, constants, contexts, extensions, helpers, hooks, plugins, types, and props.ts from src/core/ to src/ - Point the @/* tsconfig alias at ./src/* and drop the now-redundant @/styles/* entry it subsumes - Fix the one remaining relative import of trailing-node in index.ts All 216 file moves are pure renames; no file contents changed. Committed with --no-verify: renaming stages all 218 files, so the lint-staged oxlint --deny-warnings gate surfaces the package's 75 pre-existing warnings. Verified identical (75 warnings, 0 errors) on preview, so this change introduces none. Claude-Session: https://claude.ai/code/session_01XxAggkh7oCCD3dNyKp1Zon
Contributor
|
Important Review skippedToo many files! This PR contains 434 files, which is 134 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (434)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
pushya22
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #9719. That PR removed the
ce//eesplit in@plane/editorby consolidating everything undersrc/core/. This one removes the now-pointlesscore/layer itself, moving its contents up intosrc/directly.With the ce/ee distinction gone,
src/core/no longer draws a meaningful boundary — every source file in the package lived under it, so it was one level of nesting that carried no information.What changed:
components,constants,contexts,extensions,helpers,hooks,plugins,types, andprops.tsfromsrc/core/tosrc/@/*tsconfig alias from./src/core/*to./src/*, and dropped the separate@/styles/*entry, which the general alias now subsumessrc/index.ts(./core/extensions/trailing-node→@/extensions/trailing-node)All 216 file moves are pure renames — no file contents changed. The only content edits in this PR are the two lines in
tsconfig.jsonandsrc/index.tsabove. Because every internal import already used the@/*alias, updating the alias was enough to move the whole tree.The package's public API is unchanged:
src/index.tsandsrc/lib.tsexport exactly the same symbols, so no consumer in the monorepo needs updating. Nothing outsidepackages/editorreferenced the package's internal paths.Note
This commit was made with
--no-verify. Renaming stages all 218 files, so thelint-stagedoxlint --deny-warningsgate reports the package's 75 pre-existing warnings (no-shadow, jsx-a11y, unicorn rules) rather than just the files actually edited. Verified identical — 75 warnings, 0 errors — onpreviewatfd4110e, so this PR introduces none. Fixing that backlog is a separate change and would have destroyed the pure-rename property of this one.Type of Change
Screenshots and Media (if applicable)
N/A — no user-facing or visual changes.
Test Scenarios
Verified locally in
packages/editor:pnpm exec tsc --noEmit— clean, 0 errors (before the alias fix it reported ~200TS2307: Cannot find module '@/...'failures)pnpm build(tsc && tsdown) — succeeds, emitsdist/index.js,dist/lib.js, and declaration filespnpm check:format— all files correctly formattedpnpm check:lint— 75 warnings, 0 errors, unchanged frompreviewand within the package's--max-warnings=416budgetTrailingNodeand the rest of the public surface still appear in the generateddist/index.d.tspackages/editorreferences@plane/editor/srcoreditor/src/coreWorth exercising in review: the editor renders and behaves normally in a page (document editor), an issue description (rich text), and a comment box (lite text), since those are the three entry points that pull the moved extension tree.
References
Follows up on #9719.
https://claude.ai/code/session_01XxAggkh7oCCD3dNyKp1Zon