Repository navigation
refactor: remove unused keyboard dismissal preparation - #36
Draft
chrispader wants to merge 1 commit into
Draft
chrispader wants to merge 1 commit into
chrispader wants to merge 1 commit into
Conversation
Co-authored-by: Codex <noreply@openai.com>
chrispader
force-pushed
the
@chrispader/refactor/keyboard-preparation-cleanup
branch
from
November 12, 2026 09:03
bb5bc8e to
5497657
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original interactive keyboard dismissal proposal left an unused FlatList renderer and a keyboard context mounted around the app. I removed that unused path and its disabled scroll hook while keeping the active action-sheet spacing and list behavior.
Explanation of Change
This removes unused preparation from Expensify#71438 and can merge independently of the LegendList work.
Fixed Issues
$ Expensify#54270
No separate proposal is linked.
Tests
All platforms, chat scrolling and message menus
Android and iOS apps, composer
Offline tests
QA Steps
Same as Tests and Offline tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
This cleanup does not change the UI.
🤖 Generated with Codex