Skip to content

refactor: remove unused keyboard dismissal preparation - #36

Draft
chrispader wants to merge 1 commit into
@chrispader/chore/legend-list-review-basefrom
@chrispader/refactor/keyboard-preparation-cleanup
Draft

chrispader wants to merge 1 commit into
@chrispader/chore/legend-list-review-basefrom
@chrispader/refactor/keyboard-preparation-cleanup

Conversation

@chrispader

@chrispader chrispader commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

The original interactive keyboard dismissal proposal left an unused FlatList renderer and a keyboard context mounted around the app. I removed that unused path and its disabled scroll hook while keeping the active action-sheet spacing and list behavior.

Explanation of Change

This removes unused preparation from Expensify#71438 and can merge independently of the LegendList work.

Fixed Issues

$ Expensify#54270

No separate proposal is linked.

Tests

All platforms, chat scrolling and message menus

  1. Open a chat with enough messages to scroll.
  2. Scroll to older messages. The messages should stay in place when scrolling stops.
  3. Open a message's action menu.
  4. Close the menu. The same messages should remain visible.
  5. Open an expense report containing several expenses.
  6. Scroll the expense list. It should behave as before.

Android and iOS apps, composer

  1. Open a chat.
  2. Tap the message box. The keyboard should open.
  3. Type a draft long enough to scroll.
  4. Scroll inside the draft. Its text should remain editable.
  5. Navigate away from the chat.
  6. Return to the chat. The draft should remain available.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open a chat while online.
  2. Disconnect the internet.
  3. Reopen the chat. Cached messages and the message box should remain available.
  4. Scroll through the cached history.
  5. Reconnect the internet. The chat should remain usable.

QA Steps

Same as Tests and Offline tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

This cleanup does not change the UI.

🤖 Generated with Codex

Co-authored-by: Codex <noreply@openai.com>
@chrispader
chrispader force-pushed the @chrispader/refactor/keyboard-preparation-cleanup branch from bb5bc8e to 5497657 Compare November 12, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant