Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #9389.
<DeleteWithConfirmButton component="a" />fails to typecheck (Type '"a"' is not assignable to type '"button"'), although react-admin's<Button>and MUI's<Button>both accept a customcomponent.DeleteWithConfirmButtonPropsextended the non-genericButtonProps, which defaults the root component to'button'.Solution
DeleteWithConfirmButtongeneric over its root component, following the same pattern as<Button>(forwardRefcast to a generic component type).DeleteWithConfirmButtonPropsbecomes a type alias with a new optionalRootComponenttype parameter (defaulting to'button'), since an interface can't extend a type depending on a generic parameter. Existing usages are unaffected.DeleteButtonnow has an explicit type annotation (same style asDatagridandLogout). Without it, the declaration emit fails with TS4023, because its inferred type expands the new type alias down toButton's non-exportedProps. The emitted declaration resolves to the same type as before, so the public API is unchanged.` (also mentioned in the issue) is intentionally typed like , and the other navigation buttons, with a LinkBase root since it navigates via to, so I left it unchanged.
How To Test
ra-ui-materialui/button/DeleteWithConfirmButton→ With Componentyarn test-unit packages/ra-ui-materialui/src/button/DeleteWithConfirmButton.spec.tsx packages/ra-ui-materialui/src/button/DeleteButton.spec.tsxyarn typecheckAdditional Checks
masterfor a bugfix