[RFR] Fix out of boundaries pagination does not allow pagination - #2365
Merged
Merged
Conversation
djhi
approved these changes
Sep 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't display the "out of boundaries" message anymore. Instead, we get back to page 1 (when page < 1) or to the last page (when page > last Page) without showing any notice.
The first check is done in our
Pagination'scomponentDidUpdate, the second check is done in material-ui's<TablePagination>.The
ra.navigation.page_out_of_boundariesmessage is still required byPagination.handlePageChange, so I didn't remove it from translation files.Closes #2350