[RFR] Migrate ra-core actions to Typescript - #2521
Conversation
fzaninotto
left a comment
There was a problem hiding this comment.
Encouraging!
Please don't commit the yarn.lock, iy shouldn't change in this PR.
| ids: []; | ||
| }; | ||
| meta: { | ||
| accumulate: any; |
There was a problem hiding this comment.
For the metas, we need to be a bit smarter. As each meta has a special signification (and triggers a particular side effect), we probably need a subtype for accumulate, to be reused everywhere the accumulate meta is present.
ccd9f1d to
166d67a
Compare
|
Switching to RFR. All actions and reducers aren't merged, but nothing is blocking the merge and we'll continue little by little. |
|
oh, wait, back to WIP, I wanted to see if I can improve the diff to show renames instead of deletion / addition. |
|
There is no way to tell git that it's a rename when its internal heuristics don't detect it. So back to RFR. |
|
Looks good to me, there might be a lot of |
Migrate the files in the
actionfolder of thera-corepackage to Typescript