Skip to content

[RFR] Migrate ra-core actions to Typescript - #2521

Merged
alexisjanvier merged 5 commits into
masterfrom
ra-core-action-ts
Nov 12, 2018
Merged

alexisjanvier merged 5 commits into
masterfrom
ra-core-action-ts

Conversation

@ghost

@ghost ghost commented Nov 8, 2018

Copy link
Copy Markdown

Migrate the files in the action folder of the ra-core package to Typescript

@fzaninotto fzaninotto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encouraging!

Please don't commit the yarn.lock, iy shouldn't change in this PR.

Comment thread packages/ra-core/src/actions/accumulateActions.ts Outdated
Comment thread packages/ra-core/src/actions/accumulateActions.ts Outdated
Comment thread packages/ra-core/src/actions/accumulateActions.ts Outdated
ids: [];
};
meta: {
accumulate: any;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the metas, we need to be a bit smarter. As each meta has a special signification (and triggers a particular side effect), we probably need a subtype for accumulate, to be reused everywhere the accumulate meta is present.

@fzaninotto fzaninotto changed the title [WIP] Migrate ra-core actions to Typescript [RFR] Migrate ra-core actions to Typescript Nov 12, 2018
@fzaninotto

Copy link
Copy Markdown
Member

Switching to RFR. All actions and reducers aren't merged, but nothing is blocking the merge and we'll continue little by little.

@djhi djhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@fzaninotto

Copy link
Copy Markdown
Member

oh, wait, back to WIP, I wanted to see if I can improve the diff to show renames instead of deletion / addition.

@fzaninotto fzaninotto changed the title [RFR] Migrate ra-core actions to Typescript [WIP] Migrate ra-core actions to Typescript Nov 12, 2018
@fzaninotto

Copy link
Copy Markdown
Member

There is no way to tell git that it's a rename when its internal heuristics don't detect it. So back to RFR.

@fzaninotto fzaninotto changed the title [WIP] Migrate ra-core actions to Typescript [RFR] Migrate ra-core actions to Typescript Nov 12, 2018
@ghost

ghost commented Nov 12, 2018

Copy link
Copy Markdown
Author

Looks good to me, there might be a lot of any used for the actions payload. I don't know if we can be more precise on these types.

@alexisjanvier
alexisjanvier merged commit 8f0922f into master Nov 12, 2018
@alexisjanvier
alexisjanvier deleted the ra-core-action-ts branch November 12, 2018 14:07
@fzaninotto fzaninotto added this to the 2.4.2 milestone Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants