Skip to content

Add 'icon' prop to buttons - #2556

Merged
djhi merged 2 commits into
marmelab:nextfrom
afilp:patch-27
Nov 27, 2018
Merged

djhi merged 2 commits into
marmelab:nextfrom
afilp:patch-27

Conversation

@afilp

@afilp afilp commented Nov 22, 2018 •

Copy link
Copy Markdown
Contributor

We had the need to customize the icon shown on the ShowButton.

This commit changes just the ShowButton, so that you comment whether you like this change or not.

If you agree with this, let me know so that we also update the rest of the buttons located inside the button folder.

Thanks.

@fzaninotto

Copy link
Copy Markdown
Member

Love it! Would you mind going a bit further and do the same for other buttons?

@afilp

afilp commented Nov 23, 2018

Copy link
Copy Markdown
Contributor Author

Sure! That was the idea! First to see if you want it, then take the time to do the rest. I will do this most likely during the weekend.

Thanks!

@afilp

afilp commented Nov 25, 2018 •

Copy link
Copy Markdown
Contributor Author

Added 2nd commit for the rest of the buttons.

Please note that in some "class"-using buttons I moved the propTypes and defaultProps as static. This was done for consistency: Some classes used the static approach, others the named declaration at the end, now all of them use the same logic, the static one. If you prefer the other approach just let me know to do the opposite.

@djhi djhi added this to the 2.5.0 milestone Nov 27, 2018
@djhi

djhi commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

Thanks!

@djhi
djhi merged commit 741b75b into marmelab:next Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants