Add 'icon' prop to buttons - #2556
Merged
Merged
Conversation
Member
|
Love it! Would you mind going a bit further and do the same for other buttons? |
Contributor
Author
|
Sure! That was the idea! First to see if you want it, then take the time to do the rest. I will do this most likely during the weekend. Thanks! |
Contributor
Author
|
Added 2nd commit for the rest of the buttons. Please note that in some "class"-using buttons I moved the |
djhi
approved these changes
Nov 27, 2018
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had the need to customize the icon shown on the
ShowButton.This commit changes just the
ShowButton, so that you comment whether you like this change or not.If you agree with this, let me know so that we also update the rest of the buttons located inside the
buttonfolder.Thanks.