Skip to content

Fix EditButton in Datagrids using rowClick - #2686

Merged
fzaninotto merged 1 commit into
marmelab:masterfrom
plattdl:master
Dec 26, 2018
Merged

fzaninotto merged 1 commit into
marmelab:masterfrom
plattdl:master

Conversation

@plattdl

@plattdl plattdl commented Dec 20, 2018

Copy link
Copy Markdown
Contributor

Fixes a similar issue to #2457 where clicking on an Edit Button inside of a Datagrid with rowClick set to "show" doesn't handle the button event properly.

@fzaninotto
fzaninotto merged commit 079f792 into marmelab:master Dec 26, 2018
@fzaninotto

Copy link
Copy Markdown
Member

Good catch! I see the ShowButton still has the same issue, would you mind opening another PR for that one?

@fzaninotto fzaninotto added this to the 2.5.3 milestone Dec 26, 2018
@plattdl

plattdl commented Jan 2, 2019 •

Copy link
Copy Markdown
Contributor Author

@fzaninotto Done! Apologies for the delay. Was away for the holidays. Happy to help otherwise!

@fzaninotto

Copy link
Copy Markdown
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants