Conversation
phacks
force-pushed
the
fix-ie11-layout-problems
branch
from
January 13, 2019 17:03
beab316 to
380b671
Compare
Member
|
This needs thorough testing across multiple browsers |
Contributor
Author
|
@fzaninotto of course — how would you like me to proceed? |
Member
|
We use tools like BrowserStack. But I'll do the tests on this one to make sure it breaks nothing - we've had regressions in the past due to small changes in the layout CSS. |
Contributor
Author
|
@fzaninotto Hi! Did you have time to run some browser testing on this issue? Let me know if I can be of any help 🙂 |
Contributor
Author
|
@fzaninotto Hi! Do you think you will have some time to test this PR soon? cc @Kmaschta Thanks! |
Contributor
|
I booked 15min tomorrow to test that branch locally with Browserstack |
Contributor
Contributor
Author
|
@Kmaschta thanks for the review! @fzaninotto Do you think this PR can make it for the |
djhi
approved these changes
Feb 13, 2019
Member
Contributor
Author
|
@fzaninotto Oops, I can work on it next week, will keep you updated! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





















As mentioned in #2676, IE11 suffers from several layout problems where the user would have to horizontally scroll to see all content and/or images would get absurdly distorted.
philipwalton/flexbugs#170 seems to show that IE11 shows inconsistency when using
flex-basis: auto(or the shorthand version:flex: X Y auto).I tried changing
autoby0pxin such statements, and it looks like it fixed many of those layout problems in the demo app:I also had to remove the
display: flexandflex-wrap: wraponSegmentsFieldbecause IE11 has many problems withflex-wrap: wrap. The wrapping still works (Chrome + IE11) though.Navigating the demo app on Chrome showed me no visual regression, and
<Aside />components (for which theflex-basis: autowere introduced) still work as expected: