[RFR] Check minimum required props are passed to controllers - #2782
Merged
Merged
Conversation
djhi
approved these changes
Jan 17, 2019
djhi
left a comment
Contributor
There was a problem hiding this comment.
Excellent! I think we should apply that to many other components (Toolbar, Filter, etc.)
👍
Kmaschta
force-pushed
the
check-props-are-passed-to-ctrl
branch
from
January 17, 2019 15:57
d2e9f9d to
03c90a5
Compare
Contributor
Author
|
Last minute change: @djhi You're right, that's why I wrote a HOC :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we forgot to pass the props from the parent to the controller, the app displays a huge error.
Current Error Message:
New Error Message