[RFR] Display selected choices in their selection order in SelectArrayInput - #2806
Merged
Merged
Conversation
fzaninotto
approved these changes
Jan 24, 2019
Member
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behavior of the
SelectArrayInputdoesn't follow the way they are stored. I've changed the render method in theSelectArrayInputcomponent in order to fix this.In addition, this change respects the Multiple Select demo in Material-UI.
Scenario
In the following screenshot, we can find on the left the new version*, and on the right the old version.
Selection order:
Choices order:
We notice that without this PR, the
SelectArrayInputdisplays the items in the choices order instead of the selection order. However, in the storage, the items are ordered following the user selection order.Todo
renderValuemethod inSelectArrayInputto display selected choices in their selection order