Fix CreateButton not being re-translated when language change at runtime - #2842
Merged
djhi merged 1 commit intoJan 31, 2019
Merged
Conversation
…ntime The `CreateButton` is using an optimization to re-render only a certain set of keys change. However, the `translate` prop was not part of that. This was causing the component to not re-render when the translate function was updated due to languague having changed. This is now fixed by specifying the `translate` as being a prop change that causes a re-render. Fixes marmelab#2830
Contributor
Author
|
I was really lucky (or it was a real bad luck) to hit that as |
djhi
approved these changes
Jan 31, 2019
djhi
left a comment
djhi
left a comment
Contributor
There was a problem hiding this comment.
Great description. Thanks !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CreateButtonis using an optimization to re-render only a certain set of keys change. However, thetranslateprop was not part of that. This was causing the component to not re-render when the translate function was updated due to language having changed.This is now fixed by specifying the
translateas being a prop change that causes a re-render.Fixes #2830