Skip to content

Update Unit Testing documentation - #2872

Merged
fzaninotto merged 1 commit into
marmelab:masterfrom
mexitalian:patch-1
Feb 13, 2019
Merged

fzaninotto merged 1 commit into
marmelab:masterfrom
mexitalian:patch-1

Conversation

@mexitalian

Copy link
Copy Markdown
Contributor

The previous import location threw an error for me as it couldn't be found.

The previous import location threw an error for me as it couldn't be found.
@djhi

djhi commented Feb 12, 2019

Copy link
Copy Markdown
Contributor

The react-admin package just re-export what ra-core exports. So both imports should work

@Kmaschta

Copy link
Copy Markdown
Contributor

I somewhat agree with that PR: ra-core isn't documented (yet) and it might be confusing to the early adopters why we require that package in a simple unit test example.

@djhi djhi changed the title Update UnitTesting.md Update Unit Testing documentation Feb 13, 2019
@djhi djhi added this to the 2.7.2 milestone Feb 13, 2019
@djhi

djhi commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

@fzaninotto What do you think about it? I agree with @Kmaschta

@fzaninotto
fzaninotto merged commit eed959d into marmelab:master Feb 13, 2019
@fzaninotto

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants