Fix GET_MANY in ra-data-json-server data provider returns too many results - #2873
Merged
fzaninotto merged 1 commit intoFeb 15, 2019
Merged
Conversation
…lter instead of a greedy regular expression.
Member
|
Are you sure this works? I tested the |
Contributor
Author
|
This is not > const {stringify} = require('query-string')
undefined
> stringify({id: [1, 2]})
'id=1&id=2' |
Member
|
Gotcha, thanks for the explanation. |
Member
|
And thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think using the json-server
likefeature is not what we want here, since anid_like=2|33|444will match 2, 33, 444 but also 23, 133 and so forth.We could restrict the match with delimiters (
^and$) but since it supports multiple filters query, it would be simpler to use just that.