Skip to content

[RFR] Update documentation with German translation package - #3011

Closed
straurob wants to merge 6 commits into
marmelab:nextfrom
straurob:ra-tree_german_translation
Closed

straurob wants to merge 6 commits into
marmelab:nextfrom
straurob:ra-tree_german_translation

Conversation

@straurob

Copy link
Copy Markdown

This PR adds a link to the translation section. It refers to a new standalone package for the German translations of the ra-tree-ui-materialui package as propsed in PR #2998.

@Kmaschta

Kmaschta commented Mar 17, 2019 •

Copy link
Copy Markdown
Contributor

It seems that you have commits you haven't wrote in your PR.
Usually an outdated base branch issue, mind you rebase your branch against next and push again?

Comment thread docs/Translation.md Outdated
- Finnish (`fi`): [aikain/ra-language-finnish](https://github.com/aikain/ra-language-finnish)
- French (`fr`): [marmelab/ra-language-french](https://github.com/marmelab/react-admin/tree/master/packages/ra-language-french)
- German (`de`): [greenbananaCH/ra-language-german](https://github.com/greenbananaCH/ra-language-german)
- German (`de`) messages for [ra-tree-ui-materialui](https://github.com/marmelab/react-admin/tree/master/packages/ra-tree-ui-materialui) package: [straurob/ra-tree-language-german](https://github.com/straurob/ra-tree-language-german)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put that on the same line as the main German translation, and under a shorter form, like ([tree translation](xxx))

@straurob

Copy link
Copy Markdown
Author

Due to problems with my local repo I had to recreate the fork. Thus, this PR is obsolete and can be continued in #3014.

@straurob straurob closed this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants