Prevent ra-data-graphql-simple from circular dependencies issue - #3093
Merged
fzaninotto merged 1 commit intoApr 25, 2019
Merged
fzaninotto merged 1 commit into
fzaninotto merged 1 commit into
Conversation
djhi
suggested changes
Apr 5, 2019
djhi
left a comment
djhi
left a comment
Contributor
There was a problem hiding this comment.
Neat :) Thanks! Can you add some tests though?
GM-Alex
force-pushed
the
feature/ra-data-graphql-simple-circular-dependencies
branch
from
April 5, 2019 20:57
4417608 to
375cfe4
Compare
Contributor
Author
|
@djhi Done. I made a new one but I think we could extend the old one because they are nearly identically. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path prevents the
buildFieldsmethod from circular dependencies, so thatlinkedTypesare only processed if they aren't analyzed before.