Skip to content

[RFR] Relax react router dependency to avoid version mismatch - #3144

Merged
djhi merged 1 commit into
masterfrom
fix-react-router-warnings
Apr 19, 2019
Merged

djhi merged 1 commit into
masterfrom
fix-react-router-warnings

Conversation

@fzaninotto

Copy link
Copy Markdown
Member

Closes #3138

@fzaninotto

Copy link
Copy Markdown
Member Author

The warnings come from history, which is a dependency of react-router-dom. history is resolved to the latest version (4.9.0) on new projects. It complains that react-router-dom uses an outdated way of calling the history adapters. The fix consists of relaxing the react-router-dom version constraint, to have a more recent version that calls history adapters the right way.

@djhi djhi added this to the 2.8.6 milestone Apr 19, 2019
@djhi
djhi merged commit eff280e into master Apr 19, 2019
@djhi
djhi deleted the fix-react-router-warnings branch April 19, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

require("history") console warnings

2 participants