fixed AutocompleteInput popup to re-render after choice is selected - #3190
Merged
Merged
Conversation
Member
|
You seem to use different prettier settings than us. Can you please avoid reformatting on save or use our prettier preset, to minimize the coding style changes? |
Contributor
Author
|
Of course, i apologize, just ran your prettier settings. |
Member
|
You patch doesn't work. I tested on the simple example, in a Comment detail, changing the related post doesn't work anymore. |
Contributor
Author
|
This is weird, i tested it locally on the reviews component using the customer filter and it worked fine, i'll check it again |
Contributor
Author
|
I added a new case in the handleChange function, can you please retest with this modification? |
djhi
approved these changes
May 22, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a PR to fix AutocompleteInput issue #2428. I added the prop focusInputOnSuggestionClick by default to false, and since the input loses focus on suggestion selection, i had to change the state when calling handleSuggestionSelected().
Best Regards.