Skip to content

[RFR] Fix DashboardMenuItem className prop - #3357

Merged
fzaninotto merged 1 commit into
masterfrom
fix-dashboard-menu-item-classname
Jun 25, 2019
Merged

fzaninotto merged 1 commit into
masterfrom
fix-dashboard-menu-item-classname

Conversation

@Kmaschta

@Kmaschta Kmaschta commented Jun 24, 2019 •

Copy link
Copy Markdown
Contributor

Problem

When (re)using the component <DashboardMenuItem>, if pass it a className prop it is supressed by the component and not passed to its children MenuItem.

Solution

  1. Pass the className prop to its children
  2. or, let this one in the default props passed in the children

I choose the second one, because this prop isn't used anyway.

@Kmaschta Kmaschta added this to the 2.9.4 milestone Jun 24, 2019
@fzaninotto
fzaninotto merged commit b2246d9 into master Jun 25, 2019
@fzaninotto
fzaninotto deleted the fix-dashboard-menu-item-classname branch June 25, 2019 18:04
@fzaninotto

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants