Skip to content

Utility lemmas in filter.v - #2024

Merged
affeldt-aist merged 2 commits into
math-comp:masterfrom
amolinamounier:filter_utils
Jul 30, 2026
Merged

Utility lemmas in filter.v#2024
affeldt-aist merged 2 commits into
math-comp:masterfrom
amolinamounier:filter_utils

Conversation

@amolinamounier

Copy link
Copy Markdown
Collaborator
Motivation for this change

Split from #2023

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md

  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

amolinamounier added a commit to amolinamounier/mathcomp-analysis that referenced this pull request Jul 15, 2026
@amolinamounier amolinamounier mentioned this pull request Jul 15, 2026
5 tasks
@amolinamounier
amolinamounier force-pushed the filter_utils branch 3 times, most recently from 573976b to 5741664 Compare July 20, 2026 20:10
Comment thread classical/filter.v Outdated
{near F, f =1 g} -> lim (f @ F) = lim (g @ F).
Proof. by move=> /near_eq_cvgE ->. Qed.

Lemma cvg_to_eq {T : nbhsType} {F : set_system T} (l l' : T) :

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That does not look very useful a priori.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it useful in cases where the convergence is easy to close out with lemmas like cvgD, cvgM with an existential as the target, but where the end result needs some rewriting to be shown equal to the desired quantity, somewhat like is_derive_eq.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is_derive_eq comes with typeclass instances so that when it is applied, it returns only one goal (the equality). Maybe this is a difference with cvg_to_eq?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about we remove this lemma from this PR and defer its inclusion to a PR that actually uses it? (That would unlock this PR because the other lemmas looks ok to me.)

@affeldt-aist affeldt-aist added this to the 1.17.0 milestone Jul 30, 2026
@affeldt-aist
affeldt-aist merged commit 6e121ed into math-comp:master Jul 30, 2026
69 checks passed
affeldt-aist added a commit that referenced this pull request Jul 30, 2026
* Utility lemmas in filter.v

---------

Co-authored-by: Reynald Affeldt <reynald.affeldt@aist.go.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants