Repository navigation
Support testing Synapse with Postgres #323
Description
matrix-org/synapse#12024 raised the issue that, since the images we use for Synapse only support SQLite, we might be missing some pretty bad bugs. In this specific case, Complement shows Synapse's implem as passing whereas it's actually broken for any instance using PostgreSQL (which should be most Synapse instances). It sounds to me like we could really benefit from having Dockerfiles and config files for Synapse that support Postgres.
Reacted by Eric Eastwood
Activity
kegsay commentedon Feb 18, 2022
https://github.com/matrix-org/dendrite/blob/main/build/scripts/ComplementPostgres.Dockerfile is what Dendrite does.
richvdh commentedon Feb 18, 2022
This is really a subset of testing Synapse with worrkers (matrix-org/synapse#12638)
babolivier commentedon Feb 21, 2022
Is it? Being able to test with PostgreSQL would have raised matrix-org/synapse#12024 even without workers support afaict.
richvdh commentedon Feb 21, 2022
It's a subset in that, if we test with workers, we will necessarily be testing with Postgres too. I'm not saying there wouldn't be advantages to testing with Postgres as a monolith too.
babolivier commentedon Feb 21, 2022
Ah right, gotcha, thanks for clarifying.
DMRobertson commentedon May 31, 2022
Redundant now that matrix-org/synapse#12638 is closed? (And arguably not a problem for the complement repo?)