TestRoomCreationReportsEventsToMyself tests unspecified behaviour #901

Activity

1. timedoutuk commented on Jul 15, 2026

   

   timedoutuk

   on Jul 15, 2026

   ContributorAuthor

   More actions

   Joining room twice is idempotent suffers this same problem:

   complement/tests/csapi/rooms_state_test.go

   Lines 110 to 138 in 1a2baac

   	// sytest: Joining room twice is idempotent
   	t.Run("Joining room twice is idempotent", func(t *testing.T) {
   	t.Parallel()
   	roomID := bob.MustCreateRoom(t, map[string]interface{}{
   	"visibility": "public",
   	"preset": "public_chat",
   	})
   	alice.MustJoinRoom(t, roomID, nil)
   	alice.MustSyncUntil(t, client.SyncReq{}, client.SyncJoinedTo(alice.UserID, roomID))
   	firstID := *getEventIdForState(t, alice, roomID, "m.room.member", alice.UserID)
   	alice.MustJoinRoom(t, roomID, nil)
   	// Unfortunately there is no way to definitively wait
   	// for a 'potentially false second join event' without
   	// also failing the test on timeout, with the current APIs.
   	//
   	// So we take a conservative estimate of a 5-second sleep delay
   	// before we check on the server again.
   	time.Sleep(5 * time.Second)
   	secondID := *getEventIdForState(t, alice, roomID, "m.room.member", alice.UserID)
   	if firstID != secondID {
   	t.Fatalf("Both Event IDs from supposedly-idempotent room joins differ, %s != %s", firstID, secondID)
   	}

   Neither /_matrix/client/v3/join/{roomIdOrAlias} nor /_matrix/client/v3/rooms/{roomId}/join state that multiple calls have to be idempotent.