Skip to content

Update the Spaces Summary tests (MSC2946) to match the current spec - #101

Merged
clokep merged 4 commits into
masterfrom
clokep/summary-api-updates
Apr 9, 2021
Merged

clokep merged 4 commits into
masterfrom
clokep/summary-api-updates

Conversation

@clokep

@clokep clokep commented Apr 8, 2021

Copy link
Copy Markdown
Member

This fixes matrix-org/synapse#9756 by updating the Complement tests to match the current specification. The main differences are:

  • There's no longer a limit flag.
  • The summary only travels "down" to children rooms from the given root.
  • The path specifies the unstable identifier in it.

Note that this won't break Dendrite because Dendrite was not passing the tag to run these tests.

@clokep

clokep commented Apr 8, 2021

Copy link
Copy Markdown
Member Author

Vaguely related to matrix-org/pipelines#139 in that these tests can now be enabled for Synapse.

@richvdh richvdh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible to me

@clokep
clokep merged commit 13341a8 into master Apr 9, 2021
@clokep
clokep deleted the clokep/summary-api-updates branch April 9, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable spaces summary (MSC2946) tests in complement

3 participants