Repository navigation
Test against stable MSC1772 spaces identifiers - #107
Merged
Merged
Conversation
clokep
force-pushed
the
clokep/stable-spaces
branch
from
May 5, 2021 14:26
f8547ed to
97146f7
Compare
Member
Author
|
Annoyingly this will fail until there's a stable release of Synapse that supports this. 😢 (This will be v1.34.0.) |
clokep
marked this pull request as ready for review
May 5, 2021 15:46
Member
|
This is presumably because Complement doesn't support same named branches when checking out branches to test under CI? |
Member
Author
Yes, and uses synapse stable instead of develop. |
clokep
changed the title
erikjohnston
approved these changes
May 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #99Blocked on FCP matrix-org/matrix-spec-proposals#1772.