This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Repository navigation
Add whitelist/blacklist maintenance complainer to buildkite annotations - #870
Merged
Merged
Conversation
Member
Author
|
Oops, it's not. The newlines in the output are borked. Dangit |
neilalexander
self-requested a review
February 14, 2020 11:34
neilalexander
suggested changes
Feb 14, 2020
neilalexander
left a comment
neilalexander
left a comment
Contributor
There was a problem hiding this comment.
Looks totally insane, I can't believe you did that with xargs :D
Member
Author
|
Well, that's better. But we still have a failing test. |
neilalexander
approved these changes
Feb 14, 2020
neilalexander
left a comment
neilalexander
left a comment
Contributor
There was a problem hiding this comment.
Looks wonderful, I'm in awe of how you tamed xargs 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The complainer's output appears like this now:
Instead of you having to dig through the long list of logs.
Required associated SyTest PR: matrix-org/sytest#803