This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
[tracker] flake8-bugbear progression #9366
Description
This is a tracker issue for adding flake8-bugbear in short steps, and to keep track of it's progress.
The original PR was #9320, it has been split in the following PRs;
-
Addflake8-bugbeardependency, putB00in ignore list, and fix remaining violations (Add bugbear, add B00 to ignored checks, and fix 2 violation codes #9499) - Finish check-fixing PRs (in order of altering
ignorekeys):-
B00->B006,B007,B008: Add more bugbear codes #9659 -
B006,B007,B008->B007: Bugbear: Add Mutable Parameter fixes #9682 -
B007->"": Fix (final) Bugbear violations #9838
-
- Discuss and merge making flake8 explicitly
selectchecks (issue #XXXX, PR #XXXX)- Add one
Bcode onselect=(#XXXX) - Enable opinionated checks (
B90) (#XXXX)
- Add one
- (Side-quest) Update bugbear to 21.4 (which adds a new check) (#XXXX)
(Some more information in #9279 about some specifics of these checks)
(#9370 was originally part of this tracker issue, but was denied, some discussion followed)
Activity
ShadowJonathan commentedon Feb 10, 2021
Optionally i'd also like to enable
B90, (as said in #9279), or a select few of these checks, these can happen after the second PR, but just to note that.ShadowJonathan commentedon Feb 10, 2021
(made #9368 and #9369 to be deliberated for after the first PR)
Bugbear: Add Mutable Parameter fixes (#9682)
clokep commentedon Apr 20, 2021
@ShadowJonathan Looks like a lot of this is done! 🎉 Any update on here that we should add?
ShadowJonathan commentedon Apr 20, 2021
Already added all those updates, next step is "Discuss and merge making flake8 explicitly select checks", i'll make a properly-worded Process issue for that whenever i have time, currently bugbear is "there", but i'd like to also enable some of those "opinionated" checks.
Additionally, I'd wanna update bugbear to the latest version, to fix the newest checks that were added, lemme add that one now...
clokep commentedon Apr 20, 2021
I think we can just use this issue.
ShadowJonathan commentedon Apr 21, 2021
no, because in
#synapse-devwe talked about process issues/changes, which i would really like to be discussed on its own merit.This is simply a tracker issue too, I dont think it is adequate or on-topic to start talking about something like this on here.
ShadowJonathan commentedon May 19, 2022
#12600 came to the conclusion that
extend-selectwas recently added, which addresses the whole deal withselect=.I'll think about adding B90 lints in the future, but for now, this is done.