Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Import mock from unittest. - #11477

Closed
clokep wants to merge 3 commits into
developfrom
clokep/fix-bg-update-unit-tests
Closed

clokep wants to merge 3 commits into
developfrom
clokep/fix-bg-update-unit-tests

Conversation

@clokep

@clokep clokep commented Dec 1, 2021 •

Copy link
Copy Markdown
Member

These tests fail for me locally with builtins.ModuleNotFoundError: No module named 'mock'

I'm not sure why they're working in CI since we shouldn't be install mock anymore.

This also adds a license header. Broken from #11306.

@clokep
clokep requested a review from a team as a code owner December 1, 2021 14:49
@clokep

clokep commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

I think this is having some issues with async mocks. I don't understand how the original code remotely worked without mock installed though?

@clokep
clokep removed the request for review from a team December 1, 2021 16:02
@erikjohnston

Copy link
Copy Markdown
Member

I think this is having some issues with async mocks. I don't understand how the original code remotely worked without mock installed though?

We added mock back in in #11306 as mock backports support for AsyncMock?

@clokep

clokep commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

I think this is having some issues with async mocks. I don't understand how the original code remotely worked without mock installed though?

We added mock back in in #11306 as mock backports support for AsyncMock?

That's really confusing -- we put a bunch of work into removing this dependency. 😢

Anyway, it would be great to shout that dependencies updated!

@clokep clokep closed this Dec 1, 2021
@erikjohnston

Copy link
Copy Markdown
Member

Ah, sorry I didn't realise we'd done that 🙁 TBH it was mostly me raging at the amount of faff to work around lack of async utils in py3.6

@clokep

clokep commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

For cross referencing -- see #9772.

@clokep
clokep deleted the clokep/fix-bg-update-unit-tests branch December 1, 2021 16:18
@clokep

clokep commented Dec 1, 2021

Copy link
Copy Markdown
Member Author

Oh hmm, I guess we should still grab the license header here. I'll do a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants