[jkolo]

…remote_media_cache_thumbnails

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[matrixbot]

Can one of the admins verify this patch?

[erikjohnston]

@matrixbot ok to test

[erikjohnston]

Why do we want to change the index?

[jkolo]

I've changed the index because under my own use case it sometimes happen that the client requested multiple thumbnails of the same size but with different scaling methods, which violated the unique constrain.

[lukebarnard1]

@jkolo, the consensus is that we're happy merge the fix for thumbnails scaling correctly but we need a bit more time to consider modifying the thumbnail table to get rid of the UNIQUE. Any chance you could split this into two PRs?

[jkolo]

Ok, no problem 2017-02-16 14:21 GMT+01:00 Luke Barnard <notifications@github.com>:

…

@jkolo <https://github.com/jkolo>, the consensus is that we're happy merge the fix for thumbnails scaling correctly but we need a bit more time to consider modifying the thumbnail table to get rid of the UNIQUE. Any chance you could split this into two PRs? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1816 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABzpWpIsCI5cza2SOraR_Ibss5soSFImks5rdE1bgaJpZM4LlFrR> .