This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Repository navigation
Admin API to list, filter and sort rooms - #6720
Merged
Merged
Conversation
erikjohnston
previously requested changes
Jan 20, 2020
erikjohnston
left a comment
erikjohnston
left a comment
Member
There was a problem hiding this comment.
This looks good, sorry for the number of comments they're mostly just nits or removing debug logging.
erikjohnston
left a comment
erikjohnston
left a comment
Member
There was a problem hiding this comment.
I think this looks good now, just I'm not sure if we want to add support for paginating backwards?
erikjohnston
approved these changes
Jan 22, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '90a28fb47': Admin API to list, filter and sort rooms (#6720)
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6424
TODO: docs