Skip to content

ci: warm plain builder flavor - #27388

Merged
aptend merged 2 commits into
matrixorigin:mainfrom
daviszhen:ci-builder-plain-cache
Aug 20, 2026
Merged

ci: warm plain builder flavor#27388
aptend merged 2 commits into
matrixorigin:mainfrom
daviszhen:ci-builder-plain-cache

Conversation

@daviszhen

Copy link
Copy Markdown
Contributor

The CI TKE consumer builds the normal (non-coverage) MatrixOne binary with make build, but Dockerfile.ci-builder previously warmed only make build GOBUILD_OPT=-cover. Coverage instrumentation changes Go compile-cache keys, so the post-merge build missed most of the intended warm cache. Warm the plain flavor as a second build so matrixorigin/CI#426 can consume the matching cache.\n\nCompanion change for matrixorigin/CI#426 reviewer feedback.

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@XuPeng-SH XuPeng-SH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 4d4b5d9 together with the final companion matrixorigin/CI#426 flow. The second build is guaranteed to run because the Makefile build target is phony; it warms the non-coverage compile keys while preserving the coverage entries in Go’s content-addressed cache, and the final stage copies the combined cache. The companion workflow timeout and cache consumer now match this added flavor. Docker Buildx validation and diff checks are clean. No blocking findings.

@mergify

mergify Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@aptend
aptend merged commit 033f418 into matrixorigin:main Aug 20, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes [1, 9] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants