ci: warm plain builder flavor - #27388
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
left a comment
There was a problem hiding this comment.
Reviewed exact head 4d4b5d9 together with the final companion matrixorigin/CI#426 flow. The second build is guaranteed to run because the Makefile build target is phony; it warms the non-coverage compile keys while preserving the coverage entries in Go’s content-addressed cache, and the final stage copies the combined cache. The companion workflow timeout and cache consumer now match this added flavor. Docker Buildx validation and diff checks are clean. No blocking findings.
|
Tick the box to add this pull request to the merge queue (same as
|
The CI TKE consumer builds the normal (non-coverage) MatrixOne binary with
make build, butDockerfile.ci-builderpreviously warmed onlymake build GOBUILD_OPT=-cover. Coverage instrumentation changes Go compile-cache keys, so the post-merge build missed most of the intended warm cache. Warm the plain flavor as a second build so matrixorigin/CI#426 can consume the matching cache.\n\nCompanion change for matrixorigin/CI#426 reviewer feedback.