Skip to content

Fix filter geometry - #2534

Merged
willend merged 8 commits into
mccode-dev:mainfrom
ebknudsen:fix_filter_geometry
Jun 29, 2026
Merged

Fix filter geometry#2534
willend merged 8 commits into
mccode-dev:mainfrom
ebknudsen:fix_filter_geometry

Conversation

@ebknudsen

@ebknudsen ebknudsen commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

This PR adds cylinder and sphere geometries to the Filter component. They were previously only present as placeholders


Development OS / boundary conditions

Debian 13


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
    • I have used the mccode-clangformat tool to apply the standard McCode component indentation scheme
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised

@ebknudsen

Copy link
Copy Markdown
Contributor Author
image

@ebknudsen

Copy link
Copy Markdown
Contributor Author
image

@willend

willend commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Cool @ebknudsen, thanks for that! I guess one could add a solution to get the surface norm from solutions found via off_intersect to implement refraction also on OFF shapes? (Yet at best likely via a separate issue / PR.)

@willend

willend commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@ebknudsen I have updated the original issue #2523 to reflect the current status after this PR. Merging.

@willend
willend merged commit 01c7ae7 into mccode-dev:main Jun 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants