feat(#9835): add cht datasource apis for creation and update of contacts and reports by sugat009 · Pull Request #10083 · medic/cht-core

sugat009 · 2025-06-24T12:52:30Z

Description

Adds APIs for creating and updating contacts and reports.

Ticket: #9835

Code review checklist

UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design. Test it has appropriate design for RTL languages.
Readable: Concise, well named, follows the style guide, documented if necessary.
Documented: Configuration and user documentation on cht-docs
Tested: Unit and/or e2e where appropriate
Internationalised: All user facing text
Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <sugatbajracharya49@gmail.com>

…10022) Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

…and-update-of-contacts-and-reports # Conflicts: # tests/integration/api/controllers/contact.spec.js # tests/integration/api/controllers/person.spec.js # tests/integration/api/controllers/place.spec.js # tests/integration/api/controllers/report.spec.js # tests/integration/shared-libs/cht-datasource/contact.spec.js # tests/integration/shared-libs/cht-datasource/person.spec.js # tests/integration/shared-libs/cht-datasource/place.spec.js # tests/integration/shared-libs/cht-datasource/report.spec.js

github-actions · 2026-02-26T00:08:59Z

This PR is now marked "stale" after 30 days without activity. It will be closed automatically in 10 days unless you add a comment, push new changes or remove the "stale" label.

Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

…and-update-of-contacts-and-reports # Conflicts: # shared-libs/cht-datasource/src/index.ts # shared-libs/cht-datasource/src/local/contact.ts # shared-libs/cht-datasource/src/local/libs/core.ts # shared-libs/cht-datasource/src/local/libs/doc.ts # shared-libs/cht-datasource/src/local/report.ts # shared-libs/cht-datasource/test/local/contact.spec.ts # shared-libs/cht-datasource/test/local/libs/core.spec.ts # shared-libs/cht-datasource/test/local/libs/doc.spec.ts # shared-libs/cht-datasource/test/local/report.spec.ts # shared-libs/cht-datasource/test/person.spec.ts # shared-libs/cht-datasource/test/report.spec.ts # tests/integration/api/controllers/person.spec.js # tests/integration/api/controllers/place.spec.js # tests/integration/api/controllers/report.spec.js # tests/integration/shared-libs/cht-datasource/person.spec.js # tests/integration/shared-libs/cht-datasource/place.spec.js # tests/integration/shared-libs/cht-datasource/report.spec.js

…and-update-of-contacts-and-reports

This reverts commit c014f1c.

This reverts commit 6838aed.

This reverts commit 524ab15.

jkuester

Okay, @sugat009, I think this is good to go! 🚀 🚀 You might give it one more check over to make sure I did not break anything when pulling in the updates from master.

The e2e tests are struggling, but I think this is from master and not related to our changes here. (Diana said in the Dev Hour today that she was working on fixes for the e2e tests in a separate PR...)

Once again, huge shout-out to @apoorvapendse for all your work on this project! It has been a long time in coming, but I think we have finally made it! 🎉

apoorvapendse · 2026-03-05T17:38:06Z

Great!!
Thank you for taking this to completion @jkuester, @sugat009.

I just flipped through this gist and it brought back a lot of happy memories.
I miss the dev hours and the fun discussions we had during our weekly syncs and on the forum.
I'll try to show up sometime if the dev hour is still a thing.

Thank you once again for the C4GT experience and for integrating this.
@dianabarsan, @andrablaj , @antonykhaemba, @sugat009, @jkuester, @lorerod and all the other wonderful folks I met during that time; I hope you have a great year ahead and all the best for the upcoming C4GT season!

sugat009 · 2026-03-10T11:59:22Z

I reviewed and tested this. We can merge it to master. The docs PR needs to be updated as well with the changes in permissions. Working on it.

apoorvapendse and others added 10 commits June 5, 2025 13:21

feat(#9835): add ContactQualifier functions (#10015)

7c48e94

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <sugatbajracharya49@gmail.com>

feat(#9835): add ReportQualifier functions and update hasField (#…

57c5056

…10022) Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

feat(#9835): createDoc function for PouchDB (#10028)

5a2dbfb

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>

feat(#10036): add PersonQualifier and related functions (#10043)

c734c65

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>

feat(#10036): implement createPerson for local (#10056)

4281118

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

feat(#10038): add PlaceQualifier and related methods (#10057)

e0ecefe

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

feat(#9835): implement postResource for creation (#10063)

6375dcc

feat(#10036): add API support for createPerson (#10061)

579281d

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

feat(#10036): integration tests for create person (#10070)

cab2145

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

feat(#10040): add local support for createReport (#10071)

d40e65b

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com> Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

sugat009 requested a review from jkuester June 24, 2025 12:52

sugat009 linked an issue Jun 24, 2025 that may be closed by this pull request

Add cht-datasource APIs for creation and update of contacts and reports #9835

Closed

6 tasks done

sugat009 added the Type: Feature Add something new label Jun 24, 2025

sugat009 added this to CHT Community Contributions Q2 2025 Jun 24, 2025

sugat009 moved this to 💻 In Progress in CHT Community Contributions Q2 2025 Jun 24, 2025

sugat009 self-assigned this Jun 24, 2025

feat(#9835): remove lineage checks (#10081)

0ab6f8b

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

sugat009 assigned sugat009 and unassigned sugat009 Jun 25, 2025

apoorvapendse added 2 commits June 25, 2025 18:42

feat(#10038): implement createPlace local (#10065)

169a023

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

feat(#9835): add local implementation for updateDoc (#10090)

412447d

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

jkuester reviewed Jun 25, 2025

View reviewed changes

Comment thread shared-libs/cht-datasource/src/qualifier.ts Outdated

jkuester reviewed Jun 25, 2025

View reviewed changes

Comment thread shared-libs/cht-datasource/src/qualifier.ts Outdated

jkuester reviewed Jun 25, 2025

View reviewed changes

Comment thread shared-libs/cht-datasource/src/qualifier.ts Outdated

feat(#10038): add API support to create place (#10089)

98a687a

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com> Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

apoorvapendse mentioned this pull request Jun 27, 2025

chore(#9835): use Input for create Qualifiers #10094

Merged

1 of 6 tasks

apoorvapendse added 2 commits June 27, 2025 16:58

chore(#9835): use Input for create Qualifiers (#10094)

8064561

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

feat(#10038): check parent in input qualifier (#10108)

54e9076

Signed-off-by: Apoorva Pendse <apoorvavpendse@gmail.com>

andrablaj added this to CHT Community Contributions Q3 2025 Jun 30, 2025

andrablaj moved this to 💻 In Progress in CHT Community Contributions Q3 2025 Jun 30, 2025

andrablaj removed the Stale label Jan 22, 2026

jkuester mentioned this pull request Feb 23, 2026

feat(#9835): refactor create/update cht-datasource apis #10522

Merged

3 of 4 tasks

github-actions Bot added the Stale label Feb 26, 2026

sugat009 removed the Stale label Feb 26, 2026

jkuester and others added 11 commits March 3, 2026 17:12

feat(#9835): refactor create/update cht-datasource apis (#10522)

a89955a

Co-authored-by: Sugat Bajracharya <30311933+sugat009@users.noreply.github.com>

Fix linting

7ae87f3

Try to fix flaky mobile Old Messages test

524ab15

Clean up code and add missing unit tests

bf0cb1f

Merge branch 'master' into 9835-add-cht-datasource-apis-for-creation-…

3a1763a

…and-update-of-contacts-and-reports

Try to fix contact-attachment e2e tests

6838aed

Disable e2e retries to try and see og problem

c014f1c

Revert "Disable e2e retries to try and see og problem"

265ce78

This reverts commit c014f1c.

Revert "Try to fix contact-attachment e2e tests"

632990b

This reverts commit 6838aed.

Revert "Try to fix flaky mobile Old Messages test"

d92dc29

This reverts commit 524ab15.

jkuester approved these changes Mar 5, 2026

View reviewed changes

sugat009 merged commit f382785 into master Mar 10, 2026
298 of 322 checks passed

sugat009 deleted the 9835-add-cht-datasource-apis-for-creation-and-update-of-contacts-and-reports branch March 10, 2026 12:00

This was referenced May 2, 2026

Add byPhones qualifier to Contact.v1 #10973

Closed

Add byShortcodes and byExternalRefs qualifiers to Contact.v1 #10976

Open

Navigation Menu

Repository navigation

feat(#9835): add cht datasource apis for creation and update of contacts and reports - #10083

feat(#9835): add cht datasource apis for creation and update of contacts and reports#10083
sugat009 merged 53 commits into
masterfrom
9835-add-cht-datasource-apis-for-creation-and-update-of-contacts-and-reports

sugat009 commented Jun 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

jkuester left a comment

Uh oh!

apoorvapendse commented Mar 5, 2026

Uh oh!

sugat009 commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sugat009 commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code review checklist

Compose URLs

License

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Feb 26, 2026

Uh oh!

jkuester left a comment

Choose a reason for hiding this comment

Uh oh!

apoorvapendse commented Mar 5, 2026

Uh oh!

sugat009 commented Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sugat009 commented Jun 24, 2025 •

edited

Loading