Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[E-idora-create < T458-MAGE] Implement remove labels for create functions - #278

Merged
antoniofilipovic merged 12 commits into
E-idora-add-create-functionsfrom
T458-MAGE-implement-removeLabels
Aug 11, 2023
Merged

[E-idora-create < T458-MAGE] Implement remove labels for create functions#278
antoniofilipovic merged 12 commits into
E-idora-add-create-functionsfrom
T458-MAGE-implement-removeLabels

Conversation

@ind1xa

@ind1xa ind1xa commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Description

Implemented create.remove_labels and e2e tests for it

Pull request type

  • Bugfix
  • [x ] Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@ind1xa ind1xa added the status: ready PR is ready for review label Jul 31, 2023
@ind1xa
ind1xa requested a review from antoniofilipovic July 31, 2023 12:33
@ind1xa ind1xa self-assigned this Jul 31, 2023
@ind1xa
ind1xa changed the base branch from E-idora-add-create-functions to main August 1, 2023 09:27
@ind1xa
ind1xa changed the base branch from main to E-idora-add-create-functions August 1, 2023 09:27
antoniofilipovic
antoniofilipovic reviewed Aug 1, 2023
View reviewed changes
Comment thread cpp/create_module/algorithm/create.cpp
antoniofilipovic
antoniofilipovic reviewed Aug 1, 2023
View reviewed changes

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One discussion point

@antoniofilipovic antoniofilipovic added status: discuss it PR commented - needs discussion and removed status: ready PR is ready for review labels Aug 1, 2023
@ind1xa
ind1xa requested a review from antoniofilipovic August 1, 2023 13:12
@ind1xa ind1xa added status: ready PR is ready for review and removed status: discuss it PR commented - needs discussion labels Aug 1, 2023
antoniofilipovic
antoniofilipovic reviewed Aug 2, 2023
View reviewed changes
Comment thread cpp/create_module/algorithm/create.cpp Outdated
antoniofilipovic
antoniofilipovic suggested changes Aug 2, 2023
View reviewed changes

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor function and it should be good to go

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 2, 2023
@ind1xa
ind1xa requested a review from antoniofilipovic August 2, 2023 09:34
@ind1xa ind1xa added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 2, 2023
@ind1xa ind1xa changed the title [E-idora < T458-MAGE] Implement remove labels for create functions [E-idora-create < T458-MAGE] Implement remove labels for create functions Aug 2, 2023
@ind1xa ind1xa added status: draft PR is in draft phase and removed status: ready PR is ready for review labels Aug 4, 2023
@ind1xa ind1xa added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Aug 5, 2023
antoniofilipovic
antoniofilipovic reviewed Aug 6, 2023
View reviewed changes
Comment thread cpp/create_module/algorithm/create.cpp Outdated
antoniofilipovic
antoniofilipovic reviewed Aug 6, 2023
View reviewed changes
Comment thread cpp/create_module/algorithm/create.cpp Outdated
antoniofilipovic
antoniofilipovic reviewed Aug 6, 2023
View reviewed changes
Comment thread cpp/create_module/algorithm/create.cpp Outdated
antoniofilipovic
antoniofilipovic suggested changes Aug 6, 2023
View reviewed changes

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion and few discussion points

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 6, 2023
@ind1xa
ind1xa requested a review from antoniofilipovic August 7, 2023 06:30
@ind1xa ind1xa added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 7, 2023
antoniofilipovic
antoniofilipovic approved these changes Aug 9, 2023
View reviewed changes

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 9, 2023
@antoniofilipovic
antoniofilipovic merged commit c8475c9 into E-idora-add-create-functions Aug 11, 2023
@antoniofilipovic
antoniofilipovic deleted the T458-MAGE-implement-removeLabels branch August 11, 2023 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ind1xa ind1xa

Labels

status: checks failing status: ship it PR approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ind1xa @antoniofilipovic