This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[E-idora-create < T464-MAGE] Implement set rel property for create functions - #279
Merged
ind1xa merged 11 commits intoAug 11, 2023
Merged
Conversation
antoniofilipovic
left a comment
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
One discission point
antoniofilipovic
added
status: discuss it
ind1xa
added
status: ready
antoniofilipovic
suggested changes
Aug 2, 2023
antoniofilipovic
left a comment
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Refactor one function according to linked PR
antoniofilipovic
added
status: change
ind1xa
added
status: ready
ind1xa
changed the title
ind1xa
added
status: draft
ind1xa
added
status: ready
antoniofilipovic
suggested changes
Aug 6, 2023
antoniofilipovic
left a comment
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
One structural change
antoniofilipovic
added
status: change
ind1xa
added
status: ready
antoniofilipovic
approved these changes
Aug 9, 2023
antoniofilipovic
left a comment
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
antoniofilipovic
added
status: ship it
Contributor
|
Resolve conflicts and wait for checks to pass please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented create.set_rel_property and e2e correctness tests for it
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################