Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[main < T584] Implement meta.stats - #296

Merged
antoniofilipovic merged 29 commits into
mainfrom
T584-MAGE-meta-stats
Sep 1, 2023
Merged

[main < T584] Implement meta.stats#296
antoniofilipovic merged 29 commits into
mainfrom
T584-MAGE-meta-stats

Conversation

@imilinovic

@imilinovic imilinovic commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Description

Implement meta.stats online and offline version.

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added the status: ready PR is ready for review label Aug 7, 2023
@imilinovic imilinovic self-assigned this Aug 7, 2023
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/meta_module.cpp
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
@imilinovic imilinovic changed the title [main < T584] Meta.stats [main < T584] Implement meta.stats Aug 7, 2023

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to take into account multi-threading

Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp
@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Aug 9, 2023

@Josipmrden Josipmrden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, overall good job

Comment thread cpp/meta_module/algorithm/meta.cpp
Comment thread cpp/meta_module/algorithm/meta.cpp
Comment thread e2e/meta_online_test/test_online_stats_update_4/input.cyp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp
Comment thread cpp/meta_module/algorithm/meta.hpp Outdated
Comment thread cpp/meta_module/algorithm/meta.hpp Outdated
@imilinovic imilinovic added In progress and removed status: change PR reviewed - needs changes labels Aug 27, 2023
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes and that should be it

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed In progress labels Aug 28, 2023
@antepusic
antepusic self-requested a review August 28, 2023 22:52
Comment thread cpp/meta_module/algorithm/meta.cpp Outdated
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Aug 29, 2023

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antepusic antepusic added the status: ship it PR approved label Sep 1, 2023
@antoniofilipovic
antoniofilipovic merged commit a5b0896 into main Sep 1, 2023
@antoniofilipovic
antoniofilipovic deleted the T584-MAGE-meta-stats branch September 1, 2023 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: ready PR is ready for review status: ship it PR approved

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants