Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[E-nodes < T502] Implement nodes.relationship_types - #301

Merged
imilinovic merged 8 commits into
E-add-nodes-functionsfrom
T502-MAGE-relationship-types
Aug 11, 2023
Merged

[E-nodes < T502] Implement nodes.relationship_types#301
imilinovic merged 8 commits into
E-add-nodes-functionsfrom
T502-MAGE-relationship-types

Conversation

@imilinovic

Copy link
Copy Markdown
Contributor

Description

Implement nodes.relationship_types

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic added the status: ready PR is ready for review label Aug 8, 2023
@imilinovic imilinovic self-assigned this Aug 8, 2023
@imilinovic
imilinovic marked this pull request as ready for review August 8, 2023 16:12
@imilinovic imilinovic added status: draft PR is in draft phase and removed status: ready PR is ready for review labels Aug 9, 2023
@imilinovic
imilinovic marked this pull request as draft August 9, 2023 08:08
@imilinovic imilinovic added status: ready PR is ready for review and removed status: draft PR is in draft phase labels Aug 9, 2023
@imilinovic
imilinovic marked this pull request as ready for review August 9, 2023 09:29

@antepusic antepusic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would nodes.relationship_types work if the user gives a relationship like e.g. "<KNOWS>"? I think we should add a test for this case.

Also, the question from #300 applies to this module as well.

@imilinovic imilinovic added status: draft PR is in draft phase and removed status: ready PR is ready for review labels Aug 10, 2023

@antepusic antepusic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@antepusic antepusic mentioned this pull request Aug 10, 2023
16 tasks
@imilinovic
imilinovic merged commit fe98733 into E-add-nodes-functions Aug 11, 2023
@imilinovic
imilinovic deleted the T502-MAGE-relationship-types branch August 11, 2023 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: draft PR is in draft phase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants