This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[E-export < T338] Implement export_csv_graph - #325
Merged
Conversation
mpintaric55334
requested review from
Josipmrden,
antepusic,
imilinovic and
ind1xa
August 23, 2023 10:45
antoniofilipovic
self-requested a review
August 28, 2023 09:42
antoniofilipovic
suggested changes
Aug 28, 2023
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Looks good, I suggested few changes what to do
antepusic
suggested changes
Aug 30, 2023
antepusic
left a comment
Contributor
There was a problem hiding this comment.
Looks good, left a few comments. Two of them relate to several files so I’m posting them here:
- Line breaks:
csv.writerchooses the system-appropriate line break, but it’s safer to usesplit(data, "\n")in the tests (some systems use just"\n", andtrimwill remove the"\r"anyway) - I think the tests would be easier to follow if you changed the last line of the test query to
RETURN row[1] AS labels, row[7] AS type;
antoniofilipovic
suggested changes
Sep 5, 2023
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Last few changes
mpintaric55334
force-pushed
the
T338-MAGE-csv_graph
branch
from
September 6, 2023 11:04
5a96780 to
e15be64
Compare
antoniofilipovic
approved these changes
Sep 6, 2023
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly explain the changes you made here.
Pull request type
Related issues
Delete if this PR doesn't resolve any issues. Link the issue if it does.
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################