Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[main < T622] Add convert str2object - #326

Merged
antoniofilipovic merged 35 commits into
mainfrom
T-add-convert-str2object
Sep 7, 2023
Merged

[main < T622] Add convert str2object#326
antoniofilipovic merged 35 commits into
mainfrom
T-add-convert-str2object

Conversation

@mpintaric55334

Copy link
Copy Markdown
Contributor

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@mpintaric55334 mpintaric55334 added the status: ready PR is ready for review label Aug 23, 2023
@mpintaric55334 mpintaric55334 self-assigned this Aug 23, 2023
@antepusic antepusic added status: ship it PR approved and removed status: ready PR is ready for review labels Aug 30, 2023
@mpintaric55334
mpintaric55334 force-pushed the T-add-convert-str2object branch from bc65663 to a180784 Compare September 4, 2023 09:51
@antepusic
antepusic self-requested a review September 4, 2023 18:50

@antepusic antepusic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d approved this PR before, but #322 has been merged and checks are still failing – just a heads-up for us not to merge this

@antepusic antepusic added status: checks failing status: change PR reviewed - needs changes and removed status: ship it PR approved labels Sep 4, 2023
Comment thread python/convert.py Outdated

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few last changes

@antepusic antepusic removed the status: change PR reviewed - needs changes label Sep 5, 2023
@antepusic
antepusic self-requested a review September 5, 2023 09:29
@antoniofilipovic antoniofilipovic added the status: ship it PR approved label Sep 6, 2023
@mpintaric55334 mpintaric55334 added status: discuss it PR commented - needs discussion and removed status: checks failing labels Sep 7, 2023
@antoniofilipovic
antoniofilipovic merged commit 9fdeb79 into main Sep 7, 2023
@antoniofilipovic
antoniofilipovic deleted the T-add-convert-str2object branch September 7, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

status: discuss it PR commented - needs discussion status: ship it PR approved type: module

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants