This repository was archived by the owner on Jan 23, 2026. It is now read-only.
[main < T350-MAGE] Implement graphml import and export - #327
Merged
Conversation
added 2 commits
August 24, 2023 10:34
ind1xa
requested review from
Josipmrden,
antepusic,
antoniofilipovic,
imilinovic and
mpintaric55334
August 24, 2023 10:38
Comment on lines
+146
to
+155
| if graphML: | ||
| properties = { | ||
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | ||
| for key in vertex.properties.keys() | ||
| } | ||
| else: | ||
| properties = { | ||
| key: convert_to_isoformat(vertex.properties.get(key)) | ||
| for key in vertex.properties.keys() | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if graphML: | |
| properties = { | |
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| else: | |
| properties = { | |
| key: convert_to_isoformat(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| if graphML: | |
| properties = { | |
| key: convert_to_isoformat_graphML(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } | |
| continue | |
| properties = { | |
| key: convert_to_isoformat(vertex.properties.get(key)) | |
| for key in vertex.properties.keys() | |
| } |
Contributor
Author
There was a problem hiding this comment.
but wont continue go to the next vertex in ctx.graph.vertices and lines below will be skipped?
Contributor
There was a problem hiding this comment.
yes but isn't that okay?
Contributor
Author
There was a problem hiding this comment.
not really, i want those properties to be added to the node in both cases, just in different format (depending if its for graphml or not)
antoniofilipovic
suggested changes
Aug 28, 2023
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Good work, left few comments to do
antepusic
reviewed
Aug 28, 2023
antepusic
left a comment
Contributor
There was a problem hiding this comment.
Left a few comments, I'll take a more detailed look later too :)
antoniofilipovic
approved these changes
Sep 5, 2023
antoniofilipovic
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
antepusic
approved these changes
Sep 5, 2023
antepusic
approved these changes
Sep 6, 2023
…E-implement-graphml
…raph/mage into T350-MAGE-implement-graphml
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented import_util.graphml and export_util.graphml
Pull request type
######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
######################################