Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

[E-export < T343] Implement export_util.json_graph and modify export json - #334

Merged
antoniofilipovic merged 8 commits into
E-add-export-functionsfrom
T343-MAGE-json-graph
Sep 7, 2023
Merged

[E-export < T343] Implement export_util.json_graph and modify export json#334
antoniofilipovic merged 8 commits into
E-add-export-functionsfrom
T343-MAGE-json-graph

Conversation

@imilinovic

Copy link
Copy Markdown
Contributor

Description

Implement export_util.json_graph and add option to remove properties from regular export_util.json

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

######################################

@imilinovic imilinovic self-assigned this Sep 1, 2023
@imilinovic imilinovic added status: ready PR is ready for review and removed In progress labels Sep 4, 2023
@imilinovic
imilinovic marked this pull request as ready for review September 4, 2023 20:22
Comment thread python/export_util.py Outdated
Comment thread python/export_util.py Outdated
Comment thread python/export_util.py Outdated

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes

@antoniofilipovic antoniofilipovic added status: change PR reviewed - needs changes and removed status: ready PR is ready for review labels Sep 5, 2023
@imilinovic
imilinovic changed the base branch from E-add-export-functions to main September 7, 2023 06:56
@imilinovic
imilinovic changed the base branch from main to E-add-export-functions September 7, 2023 06:57
@imilinovic imilinovic added status: ready PR is ready for review and removed status: change PR reviewed - needs changes labels Sep 7, 2023

@antoniofilipovic antoniofilipovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@antoniofilipovic antoniofilipovic added status: ship it PR approved and removed status: ready PR is ready for review labels Sep 7, 2023
@imilinovic
imilinovic changed the base branch from E-add-export-functions to main September 7, 2023 12:56
@imilinovic
imilinovic changed the base branch from main to E-add-export-functions September 7, 2023 12:56
@antoniofilipovic
antoniofilipovic merged commit a78fb70 into E-add-export-functions Sep 7, 2023
@antoniofilipovic
antoniofilipovic deleted the T343-MAGE-json-graph branch September 7, 2023 13:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants