feat: SSO authentication on coordinators - #4399
Merged
Merged
Conversation
as51340
added
feature
as51340
changed the title
as51340
changed the title
as51340
marked this pull request as ready for review
July 20, 2026 06:11
as51340
changed the title
andrejtonev
reviewed
Jul 21, 2026
andrejtonev
reviewed
Jul 30, 2026
andrejtonev
approved these changes
Jul 31, 2026
Re-read the --context-yaml file before starting instances so startup flags edited while instances are stopped take effect on the next start, without restarting the runner. The context dict is mutated in place because the interactive loop and the ACTIONS closures hold a reference to it. A missing or unparsable file keeps the current description instead of tearing down the session. Instances that are still running warn that their reloaded args are ignored, and a running instance removed from the YAML keeps its old description so it can still be stopped from the runner.
|
Contributor
Author
Tracking
Standard development
CI Testing Labels
Documentation checklist
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables SSO HA authentication on coords. SSO is enabled when
--auth-module-mappingsflag is set to true and role with write privilege exists. In that case basic auth using username and password is forbidden.Also:
COORDINATORprivilege is removedThis PR removes the
COORDINATORprivilege (Permission::COORDINATOR,AuthQuery::Privilege::COORDINATOR) and drops it from theprivilegegrammar rule. It never gated any operation, but it was grantable, so removing it is user visible:GRANT/DENY/REVOKE COORDINATORno longer parses. Any provisioning script, migration, or IaC step that runs e.g.GRANT COORDINATOR TO some_role;now fails with a syntax error instead of succeeding. Such statements must be deleted — they were always no-ops.SHOW PRIVILEGESno longer reportsCOORDINATOR, and it is gone fromkPermissionsAll/kPrivilegesAll, soGRANT ALL PRIVILEGESno longer includes it. Tooling that snapshots or diffs the full privilege list sees one fewer entry.Permissions::GetGrants()/GetDenies()iteratekPermissionsAll, so a stale bit is simply never reported and never checked — it is inert. It also can no longer be revoked via Cypher, which is harmless for the same reason.COORDINATOR_READ/COORDINATOR_WRITEprivileges are not a drop-in replacement. They are coordinator-only:EditPermissionsrejects them on a data instance, and they gate the coordinator Cypher surface for SSO sessions. AGRANT COORDINATORon a data instance has no equivalent to rewrite it to, because it never granted anything in the first place.Documented as a breaking change in the v3.13.0 release notes.