Skip to content

Fix: Reduce excessive recentering #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cizl merged 5 commits into from
Aug 3, 2023
Merged

Fix: Reduce excessive recentering #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
faa9eed
New: Add zoom and recenter functions
cizl Aug 1, 2023
54d87c6
Fix: reuse this.render
cizl Aug 1, 2023
e6d5802
Fix: Remove excessive recenterings
cizl Aug 3, 2023
d81b20f
Merge branch 'new/simulator-fixes' into new/fix-recenter
cizl Aug 3, 2023
0010070
Fix: Remove unused code
cizl Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/views/orb-map-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ export class OrbMapView<N extends INodeBase, E extends IEdgeBase> implements IOr
if (this._renderer.isInitiallyRendered) {
this._leaflet.invalidateSize(false);
this._renderer.render(this._graph);
this.recenter();
}
}

Expand Down
9 changes: 0 additions & 9 deletions src/views/orb-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ export class OrbView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
this._simulator.on(SimulatorEventType.SIMULATION_END, (data) => {
this._graph.setNodePositions(data.nodes);
this.render();
this.recenter();
// this._isSimulating = false;
this._onSimulationEnd?.();
this._onSimulationEnd = undefined;
Expand Down Expand Up @@ -212,16 +211,9 @@ export class OrbView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
const edgePositions = this._graph.getEdgePositions(edgeFilter);

this._simulator.mergeData({ nodes: nodePositions, edges: edgePositions });
// this._simulator.simulate();
},
onRemoveData: (data) => {
this._simulator.deleteData(data);
/*
const nodePositions = this._graph.getNodePositions();
const edgePositions = this._graph.getEdgePositions();
this._simulator.updateData({ nodes: nodePositions, edges: edgePositions });
this.render();
*/
},
});
}
Expand Down Expand Up @@ -618,7 +610,6 @@ export class OrbView<N extends INodeBase, E extends IEdgeBase> implements IOrbVi
this._renderer.height = containerSize.height;
if (this._renderer.isInitiallyRendered) {
this._renderer.render(this._graph);
this.recenter();
}
}

Expand Down