New: Add removal functions

[AlexIchenskiy]

This PR introduces functions for removing all data, nodes (the same functionality as removing all the data), or edges by reusing existing remove function. It can be used as follows:

orb.data.removeAll();
orb.data.removeAllNodes();
orb.data.removeAllEdges();

[tonilastre]

Overall looks great! There is just one comment on the callback data.

[tonilastre]

As a user (internal or external) I would expect to receive in the callback all nodes and edges that have been removed. You are forwarding the data that you've received which doesn't necessarily mean that those have been removed, e.g.

In my graph I have these nodes and edges

• Nodes: 1, 2, 3
• Edges A (1-2), B (2-1), C(1-3)

I call remove with nodes = 1, 3, 5 and edges = C, D. But actually nodes 1, 3 will be removed and all edges will be removed (A, B, C). So instead of receiving [1, 3, 5], [C, D] in the callback, I would expect to receive [1, 3], [A, B, C].

[AlexIchenskiy]

This is the most elegant solution I've found so far, but I'm open to suggestions for any more performant/readable alternatives

[tonilastre]

This can be slow, so I would suggest creating utility function, e.g. dedupArrays that receive a generic array, or multiple arrays and dedups their values - using set or map.

E.g.

dedupArrays([1, 2, 3], [1, 2]) -> [1, 2, 3])
dedupArrays([1, 2, 3], [1, 2], [5, 6]) -> [1, 2, 3, 5, 6])
dedupArrays([1, 2, 3], [1, 2], [5, 6], [], [6, 7]) -> [1, 2, 3, 5, 6, 7])

[tonilastre]

This return type is cool. I would maybe extract it into an interface/type. Also, just for a sake of consistency, I would maybe consider returning the same type on _removeEdges - right now, nodeIds will be always empty, but in the future if we add "removeConnectingNodesfor edges, then the API still holds and can use the returned object with bothnodeIdsandedgeIds`.

[tonilastre]

This can be slow, so I would suggest creating utility function, e.g. dedupArrays that receive a generic array, or multiple arrays and dedups their values - using set or map.

E.g.

dedupArrays([1, 2, 3], [1, 2]) -> [1, 2, 3])
dedupArrays([1, 2, 3], [1, 2], [5, 6]) -> [1, 2, 3, 5, 6])
dedupArrays([1, 2, 3], [1, 2], [5, 6], [], [6, 7]) -> [1, 2, 3, 5, 6, 7])

[tonilastre]

Looks good! I've added a small detail for a better code quality.

[tonilastre]

Just a small detail here. Whenever you create a new object or an array, always add a type. Types will help you to raise warning if you for example change type in the future.

const removedData: IGraphObjectsIds = {
...

Also, this object should be within if on line 290 because you want to create this object only if settings exists and settings.onRemoveData exists, otherwise time and memory is wasted if settings is not called at all.