RegionSystem::load() Always Returns true (Ignores Read Failures)

[jirogit]

Problem

src/helpers/RegionMap.cpp
RegionSystem::load() tracks file read success using a success flag, but the function always returns true at the end:

file.close();
return true;

This ignores any read failures that may have occurred during loading.

Why This Is a Problem

If the file is:
Truncated
Corrupted
Partially written

load() will still report success, leading to:

Silent data corruption
Incomplete region tables
Difficult debugging of storage issues

Expected Behavior

load() should return false if any read operation fails.

Proposed Fix

Replace:
return true;
With:
return success;

Impact

Improves reliability and ensures proper error propagation when region storage fails.

---

I guess I need to write a pull request, right?

[github-actions]

This issue is stale because it has been open for 60 days with no activity. Remove the stale label or add a comment if this issue is still relevant, otherwise this issue will automatically close in 7 days.

[jirogit]

Still relevant — same bug family as #1880/#2372 (silent failure masking on the read path this time). Will track alongside the /regions3 migration.

[liamcottle]

Thanks! I've merged in your PR #2372 :)