promicro_washtastic variant proposal - #1129
Closed
Treehouse-00 wants to merge 1 commit into
Closed
Conversation
Although the Washtastic is a DIY board, it's a popular one with increasing deployments. A feature of the Washtastic, to increase its dynamic range, is a non-1:1 voltage bridge. This creates a challenging and frustrating scenario for repeater managers looking for accurate voltage readings, especially in dynamic weather situations. This PR is a very simple proposed changed, creating a promicro variant "promicro_washtastic" — the only change is the ADC_MULTIPLIER to more accurately report voltage for Wasthastic users looking for a flash that "just works". We recognize and empathize with efforts to decrease "bloat", but believe that Washtastic proliferation has reached a point where a bespoke firmware may be warranted. Validated on a Wastastic v4. At charge cutoff, the MeshCore iOS app reported 4.06v while a direct multimeter probe of the 18650 taken at the same time reported 4.059v Thank you for considering this minor but potentially very helpful addition to the supported devices.
Member
|
Alternatively PR #1133 would allow setting adc.multiplier via CLI instead. |
Member
|
PR #1133 will take care of this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although the Washtastic is a DIY board, it's a popular one with increasing deployments. A feature of the Washtastic, to increase its dynamic range, is a non-1:1 voltage bridge. This creates a challenging and frustrating scenario for repeater managers looking for accurate voltage readings, especially in weather conditions pushing the limits of the onboard mppt.
This PR is a very simple proposed addition, creating a promicro variant "promicro_washtastic" — the only change is the ADC_MULTIPLIER to more accurately report voltage for Wasthastic users looking for a firmware that "just works".
We recognize and empathize with efforts to decrease "bloat", but believe that Washtastic proliferation has reached a point where a bespoke firmware may be warranted.
Validated on a Wastastic v4. At charge cutoff, the MeshCore iOS app reported 4.06v while a direct multimeter probe of the 18650 taken at the same time reported 4.059v
Thank you for considering this minor but potentially very helpful addition to the supported devices.