ThinkNode M1 GPS fixes - #1445
Merged
Merged
Conversation
Member
|
Works for me, thanks! The addition of the GPS screen is nice :) I miss using this little device after moving to the WioTracker L1 Pro... |
|
Can this be integrated in the normal Firmware for people like me, which are happy to be able using the Web Flasher? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken GPS on ThinkNode M1 and adds few missing pieces.
fix: added getLocationProvider() override which is required for GPS to work after previous refactoring of SensorManager.
feat: added GPS page in the new UI
feat: pass rtc_clock so that GPS can sync clock
Tested and working.
Closes #1285